Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 deprecate rolloutAfter in cluster topology #8324

Merged
merged 1 commit into from
Mar 21, 2023
Merged

🌱 deprecate rolloutAfter in cluster topology #8324

merged 1 commit into from
Mar 21, 2023

Conversation

ykakarap
Copy link
Contributor

What this PR does / why we need it:

Cluster.spec.topology.rolloutAfter is currently unused and does not provide any functionality.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Based on: #5218 (comment)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 21, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 21, 2023
ykakarap
ykakarap commented Mar 21, 2023
View reviewed changes
Copy link
Contributor Author

@ykakarap ykakarap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow-up: To add an entry for this in the v1.4-to-v1.5 page in the CAPI book once the page is ready.

@ykakarap ykakarap mentioned this pull request Mar 21, 2023
Closed
@sbueringer
Copy link
Member

sbueringer commented Mar 21, 2023 •
edited
Loading

Follow-up: To add an entry for this in the v1.4-to-v1.5 page in the CAPI book once the page is ready.

Is this relevant to provider authors?
(Just noticing that we want to add a lot of stuff to the document which doesn't seem to be relevant to provider authors, probably because of a lack of being able to write user-facing notes)

@sbueringer
Copy link
Member

sbueringer commented Mar 21, 2023 •
edited
Loading

+1 for the deprecation in general

Also +1 to cherry-pick into v1.4. In any case we would remove the field with v1beta2, but it's better if we communicate the deprecation / that the field has no function as early as possible.

@ykakarap ykakarap force-pushed the deprecate-cluster-topology-rolloutAfter branch from 2d2d5a9 to f3654a9 Compare March 21, 2023 05:01
@ykakarap ykakarap force-pushed the deprecate-cluster-topology-rolloutAfter branch from f3654a9 to b307ab8 Compare March 21, 2023 05:09
@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 21, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5c82f749363b5e61f8257ff711950ce60b9eef5a

killianmuldoon
killianmuldoon approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2023
@killianmuldoon
Copy link
Contributor

/cherry-pick release-1.4

@k8s-infra-cherrypick-robot
Copy link

@killianmuldoon: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot merged commit 0d3a728 into kubernetes-sigs:main Mar 21, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone Mar 21, 2023
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Mar 21, 2023
Merged
@k8s-infra-cherrypick-robot
Copy link

@killianmuldoon: new pull request created: #8326

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@elmiko
Copy link
Contributor

elmiko commented Mar 22, 2023

discussed this on the meeting today, several +1s

@johannesfrey
Copy link
Contributor

/area clusterclass

@k8s-ci-robot k8s-ci-robot added the area/clusterclass Issues or PRs related to clusterclass label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@killianmuldoon killianmuldoon killianmuldoon approved these changes

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

Assignees

@sbueringer sbueringer

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/clusterclass Issues or PRs related to clusterclass cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.
7 participants
@ykakarap @sbueringer @k8s-ci-robot @killianmuldoon @k8s-infra-cherrypick-robot @elmiko @johannesfrey